Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use active username rather than username stored in mongo #225

Merged
merged 2 commits into from
Jul 11, 2024
Merged

use active username rather than username stored in mongo #225

merged 2 commits into from
Jul 11, 2024

Conversation

arcinfini
Copy link
Contributor

Resolves #205

A simple one-liner solution.

@arcinfini arcinfini linked an issue Jul 10, 2024 that may be closed by this pull request
[Bug]: infractions command shows old username. #205
Closed
sloth-ontabasco
sloth-ontabasco requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@sloth-ontabasco sloth-ontabasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that you are assigning the latest display_name in the constructor. Are we ever calling this constructor in the context of a user that does not exist in the server? If so, would those cases be handled without exception?

@arcinfini
Copy link
Contributor Author

arcinfini commented Jul 10, 2024 •
edited
Loading

@sloth-ontabasco with the new discord username system the display name is their global nickname they have assigned to themselves. In my case it would be Source instead of arcinfini which is my unique discord username

I see what you are saying..

@arcinfini
Copy link
Contributor Author

image

Tested with a bot that is not in a server with you. It gets the display_name property correctly.

@sloth-ontabasco sloth-ontabasco merged commit 4daf197 into staging Jul 11, 2024
2 checks passed
@sloth-ontabasco sloth-ontabasco deleted the bugfix/issue-0205 branch July 11, 2024 06:33
@arcinfini arcinfini mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloth-ontabasco sloth-ontabasco sloth-ontabasco approved these changes

@Utkarsh-Patel-13 Utkarsh-Patel-13 Awaiting requested review from Utkarsh-Patel-13 Utkarsh-Patel-13 is a code owner

@KvantOrav KvantOrav Awaiting requested review from KvantOrav KvantOrav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: infractions command shows old username.
2 participants
@arcinfini @sloth-ontabasco